Module talk:UnitData

Feedback
Here is my feedback, feel free to make change or not based on what I'll said (forgive my english which may be wrong):
 * The visual rendering is less good than the template's one:
 * Icons of the third column (weapon, skill, assist...) are too close from stats.
 * Separation boxes or similar may improve reading (like on the template).


 * Accessory icon would be better below the picture as it only change the unit's aspect.
 * Why not display directly the accessory.


 * Blessing icon need to be enlarged.
 * Moreover legendary/mythic hero would need one as default.
 * On that case, talk about its effect for other blessed hero.


 * Display the cooldown before the activation of special instead of the reduction on it.
 * Display it for each special, not only those with reduction.

I hope that will help you. Pival13 (talk) 19:11, 19 July 2019 (UTC)
 * Dragonflowers may be implement because it is possible than we'll have a Tactics Drills based on them one day.
 * There is currently a problem which break everything. You can see it on Mystery Trial and The Path to Victory as I tried to use the module.


 * The new design is tentative and came from a discussion on Discord a long time ago; when we are sure the new module reduces the include size enough even on the most intensive map pages, we should have a lot more freedom adding extra markup elements to the generated tables.
 * Some accessory icons become too small compared to the surrounding text, so only the accessory type is displayed.
 * Special cooldown count is doable without extra queries, since the database has the required fields for that. If it is displayed on every unit, it will most likely show up as a short piece of text next to the Special skill, instead of an icon.
 * Dragonflowers can be added when they appear in map unit definitions. For the same reason, blessings don't need to be there either because I do not think any map uses them, and Legendary / Mythic effects do nothing without blessings on other units, so these too are not displayed. The current  parameter is mostly copied from the old template for compatibility. It doesn't seem the current template actually supported blessings in the first place.
 * Like the tabber templates before, difficulty goes into the parameter name itself rather than a  template parameter. Those pages have been fixed. --HertzDevil (talk) 11:00, 20 July 2019 (UTC)
 * Dragonflowers can be added when they appear in map unit definitions. For the same reason, blessings don't need to be there either because I do not think any map uses them, and Legendary / Mythic effects do nothing without blessings on other units, so these too are not displayed. The current  parameter is mostly copied from the old template for compatibility. It doesn't seem the current template actually supported blessings in the first place.
 * Like the tabber templates before, difficulty goes into the parameter name itself rather than a  template parameter. Those pages have been fixed. --HertzDevil (talk) 11:00, 20 July 2019 (UTC)
 * Like the tabber templates before, difficulty goes into the parameter name itself rather than a  template parameter. Those pages have been fixed. --HertzDevil (talk) 11:00, 20 July 2019 (UTC)
 * Like the tabber templates before, difficulty goes into the parameter name itself rather than a  template parameter. Those pages have been fixed. --HertzDevil (talk) 11:00, 20 July 2019 (UTC)

Cooldown count
I think the cooldown count should only be displayed on the template if it's not the default. Endilyn (talk) 18:55, 21 July 2019 (UTC)
 * The initial cooldown count is only displayed when it is not equal to the maximum cooldown count. Since the game always displays a cooldown count on every unit anyway, the module shows the maximum cooldown count as long as the unit equips a Special skill, although the counts can be colored based on whether they are accelerated or slowed (with appropriate hover texts). --HertzDevil (talk) 16:12, 24 July 2019 (UTC)

Error
An error occurs sometime when you had unit row without adding the unit. See Sothis: Girl on the Throne (map) Pival13 (talk) 05:36, 1 August 2019 (UTC)

Derived map settings
I wondered, why is there odd and even settings for chain challenge? I mean, cc_story_oddX_single is the same as cc_story_evenX_single, no matter the value of X. The same applied for paralogue chain challenge. Even the *_cx019 are similar. And concerning double, it would be easier and more intuitive to just numbered them from 1 to 10. The only relevant case are blessed grounds as they really differ between odd and even. Pival13 (talk) 18:58, 18 April 2020 (UTC)