Talk:Steady Stance

Steady Stance 4 cannot be equipped by staff users
Should we store class restrictions for each Passive skill instead of each group, or leave it as is and check for "Steady Stance 4" explicitly in every query? --HertzDevil (talk) 05:45, 21 November 2018 (UTC)
 * It's probably more correct to store each passive skill separately because they are all technically different skills. Here is my plan:


 * This new Passive table merges the fields of PassiveGroup and PassiveSingle.  will connect different levels of a passive together. Afterwards, PassiveGroup and PassiveSingle will become deprecated and eventually deleted after all usages switch to the new table. If there is any problems with this plan please let me know. Endilyn (talk) 06:30, 21 November 2018 (UTC)
 * If table migration is inevitable, I am thinking if we could take this one step further and merge all skill tables into one. Here is a rough plan:
 * {|class="wikitable"

! New column !! Weapons meaning !! Assists meaning !! Specials meaning !! Passives meaning ! GroupName ! Name ! Scategory ! Icon ! Effect ! Required ! Exclusive ! SP ! CanUseMove ! CanUseWeapon ! StatModifiers ! Cooldown ! RandomAllowed ! SkillBuildCost
 * colspan=3|, because they have no numbers ||
 * ||colspan=3|
 * colspan=4| Use values from SkillTypes, this replaces
 * colspan=4| Follow Template:InlineSkill's rules, this should also deprecate
 * colspan=4|
 * colspan=4|
 * colspan=4|
 * colspan=3|  ||
 * ||colspan=3|
 * colspan=4|
 * ||colspan=2| null or 0,0,0,0,0 ||
 * colspan=2| Special trigger offset (e.g. 1 for Blade tomes) ||  || Special trigger offset
 * colspan=4|
 * colspan=3|  || Cache them with   as well
 * }
 * PassiveSeals will be modified to contain one row per seal instead of skill group so that joins with the skill table are possible. This removes . (Update: This is now done with SacredSealCosts.)
 * Other fields still have to be stored in their respective tables because it is unlikely the other skill categories will use them. These are:
 * Weapons:,  ,  ,  ,
 * Assists:
 * If we go along this route we might eventually add refined weapons into the same table, for example by also storing  into the skills table (most likely the weapon refine template's arguments go into the navbox and the template becomes query-only). --HertzDevil (talk) 09:21, 24 November 2018 (UTC)
 * This seems like a good idea.
 * I'm thinking that maybe seals could be stored as a skill too. I'm not too sure, but I think that the game's seals could theoretically have a different effect than the skill it's based on since it is a separate skill but with a different category. It's highly unlikely that will ever happen and our current system already does not support this case, so I'm not sure if it's worth doing this.
 * and  could probably be merged into one, and Passives or other could have this null similar to   for Assists.
 * could probably be deleted since weapon images follow consistent rules now (Weapon page name parsed through Template:MF). Though, it will need to be re-added if a plus weapon ever get a different sprite than its non-plus version.
 * Yes, refined weapons will need to be stored as a skill with  and this will solve "Template:EnemyData does not account for refined Yato (all paths), refined Mystletainn (Skill1), and refined Basilikos (Skill1) in stat calculations" in the to-do list.
 * I don't know about  following Template:InlineSkill's rules exactly. Some usages might prefer Fury W.png over a generic weapon icon Icon_Skill_Weapon.png, or vice versa. I think   should only store the images or icon specific to that skill and that any templates querying should decide what to do. So it would be null for Assists and Specials and non-refined weapons.
 * is useless since all the information is already present in . I left it there after creating   for backwards-compatibility and to simplify queries (List of fields are tedious to deal with that I feel like sometimes it's easier to just store comma separated strings than use Cargo's "list of" fields). It can probably be deleted.
 * I would rename  to   (just for more clarity, so that it is known that this field is for exact in-game text even if it is wrong or misleading about what the skill does (and also because it is officially referred to as a description)).
 * {|class="wikitable"

!colspan=5|Revised table ! New column !! Weapons meaning !! Assists meaning !! Specials meaning !! Passives meaning ! GroupName ! Name ! Scategory !Range ! Icon ! Path ! Description ! Required ! Exclusive ! SP ! CanUseMove ! CanUseWeapon ! StatModifiers ! Cooldown ! RandomAllowed ! SkillBuildCost
 * colspan=3|, because they have no numbers ||
 * ||colspan=3|
 * colspan=4| Use values from SkillTypes, this replaces
 * colspan=2|null
 * colspan=2|null
 * colspan=2|null
 * colspan=4| Icon of the refined weapon or passive. Null for Assists, Specials, and Weapons that have no icon.
 * colspan=3|null
 * colspan=3|null
 * colspan=4|
 * colspan=4|
 * colspan=4|
 * colspan=3|  ||
 * ||colspan=3|
 * colspan=4|
 * ||colspan=2| null or 0,0,0,0,0 ||
 * colspan=2| Special trigger offset (e.g. 1 for Blade tomes) ||  || Special trigger offset
 * colspan=4|
 * colspan=3|  || Cache them with   as well
 * } Leftover fields:,  . Should these be merged as well to simplify the querying process or kept separate? I personally think they should be merged because of that. Endilyn (talk) 20:56, 24 November 2018 (UTC)
 * Some comments:
 * Seals do not have a different category from the passive skills they are based on; Iote's Shield is the same skill whether it is a slot A passive or a seal. All passives can be used as seals if placed directly inside map files, the "seal" category only means that the skill can never be used as a passive skill.
 * will become  because the former is a reserved keyword.
 * is actually unused right now, and the skill descriptions are currently consistent enough that we can query them instead (this is done on Armor for example). Following the game's definitions, this field would use Template:WeaponList while a new  field uses Template:MoveList, but since apparently nothing on the wiki uses this field, I will keep it as is.
 * will be done at a later stage after the skill tables are merged. Only passives / seals will have icons for a while. --HertzDevil (talk) 21:30, 25 November 2018 (UTC)
 * To be consistent with certain other tables,  will be back in order to disambiguate the different forms of Falchion and Missiletainn, because page name alone is no longer sufficient to derive skill prerequisites uniformly. Icons will still be derived from   rather than , because not all icons can be derived from the latter (which tables like WeaponTypes can). --HertzDevil (talk) 17:32, 27 November 2018 (UTC)
 * Now that the master table is built, how do we represent different restrictions in the passive skill template? --HertzDevil (talk) 15:45, 27 November 2018 (UTC)